From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Wolfgang Link <w.link@proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [Patch v2 access-control] fix #2947 login name for the LDAP/AD realm can be case-insensitive
Date: Mon, 7 Sep 2020 11:29:49 +0200 [thread overview]
Message-ID: <99c0d2d7-2840-35b0-1ccd-bb627a417d57@proxmox.com> (raw)
In-Reply-To: <2106163366.840.1599468174228@webmail.proxmox.com>
On 07.09.20 10:42, Wolfgang Link wrote:
> No I missed your mail.
> Will fix it and resend it.
Please also include my proposed change from then:
On 28.08.20 14:39, Thomas Lamprecht wrote:
> And we then actually want to use this method also in the API call for adding
> new users, to ensure an admin do not accidentally adds the case-sensitive same
> user multiple times.
Also, "lookup_username" does not seem to fit the API module much, I'd rather
put it in the more general PVE::AccessControl module.
prev parent reply other threads:[~2020-09-07 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 8:36 Wolfgang Link
2020-09-07 8:20 ` Dominik Csapak
2020-09-07 8:42 ` Wolfgang Link
2020-09-07 9:29 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c0d2d7-2840-35b0-1ccd-bb627a417d57@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.link@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox