From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox
Date: Mon, 22 Apr 2024 15:24:27 +0200 [thread overview]
Message-ID: <998214a0-4aac-4372-944f-9c618e027cc7@proxmox.com> (raw)
In-Reply-To: <e422ad73-49ef-4598-92c1-f7a15419cec2@proxmox.com>
Am 22.04.24 um 15:16 schrieb Dominik Csapak:
> On 4/22/24 15:11, Fiona Ebner wrote:
>
>>
>> Should we display some hint that Intel can/should also be used even if
>> you have an AMD? Maybe even just in the text we display, like "Intel
>> (also used for AMD)" but hope somebody can come up with something better.
>>
>>
>
> mhh.. i mean it is a virtual device, so should we also add this info
> for e.g. e1000 devices?
>
But with Intel/AMD, one is inclined to assume there is a dichotomy.
Personally, I'd go in assuming the "Intel" setting is wrong with my AMD
CPU and so might many users.
> since it's in the advanced section and it is documented in pve-docs,
> i'd leave it out here (we can still add a notice later if users
> are confused, but most users won't use/need it anyway)
Yes, we could also wait. But if the confusion can be avoided/reduced
without much effort, I think it's worth doing up-front.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-22 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 8:50 Markus Frank
2024-04-15 8:50 ` [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings Markus Frank
2024-04-22 13:13 ` Fiona Ebner
2024-04-22 13:18 ` Dominik Csapak
2024-04-22 13:19 ` Fiona Ebner
2024-04-22 13:21 ` Thomas Lamprecht
2024-04-22 13:22 ` Dominik Csapak
2024-04-22 13:11 ` [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox Fiona Ebner
2024-04-22 13:16 ` Dominik Csapak
2024-04-22 13:24 ` Fiona Ebner [this message]
2024-04-22 17:58 ` Thomas Lamprecht
2024-04-22 13:11 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998214a0-4aac-4372-944f-9c618e027cc7@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox