From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 common] fix #3153: INotify: adding comment of interface to inet6 section when this is the only section
Date: Mon, 28 Jun 2021 15:03:09 +0200 [thread overview]
Message-ID: <996c2d9a-b296-7484-262f-dd31e5b85893@proxmox.com> (raw)
In-Reply-To: <20210625122937.2910309-1-l.stechauner@proxmox.com>
On 25.06.21 14:29, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> changes to v1:
> * using delete instead of undef
> * added length check for families
>
You were right regarding the "inet6" only logic, but it should not hurt to make it
more specific either and having more limited assumptions (i.e., that the serializer
has the invariant of merging those comment properties) is often more robust, so I'd
have slightly preferred this variant, but just for the record as you went for the
"right" one anyway.
> src/PVE/INotify.pm | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-06-28 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 12:29 [pve-devel] " Lorenz Stechauner
2021-06-28 13:03 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=996c2d9a-b296-7484-262f-dd31e5b85893@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox