From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] ui: rbd: cephfs: add keyring/secret field for external clusters
Date: Mon, 24 Jan 2022 16:26:43 +0100 [thread overview]
Message-ID: <993d6b7d-0099-915d-55cf-7c7e9455c5a5@proxmox.com> (raw)
In-Reply-To: <31f9023f-17cc-44d5-f30c-3f2f1ecec4ba@proxmox.com>
On 1/24/22 13:54, Fabian Ebner wrote:
> Am 26.11.21 um 17:44 schrieb Aaron Lauterer:
>> Manual switching of xtype because binding 'hidden' does not work with
>> pmxDisplayEditField.
>>
>
> Except for two style nits:
>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
> Tested-by: Fabian Ebner <f.ebner@proxmox.com>
>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> www/manager6/storage/CephFSEdit.js | 39 ++++++++++++++++++++----------
>> www/manager6/storage/RBDEdit.js | 11 +++++++++
>> 2 files changed, 37 insertions(+), 13 deletions(-)
>>
>> diff --git a/www/manager6/storage/CephFSEdit.js b/www/manager6/storage/CephFSEdit.js
>> index 92fdfe63..89459ba8 100644
>> --- a/www/manager6/storage/CephFSEdit.js
>> +++ b/www/manager6/storage/CephFSEdit.js
>> @@ -101,20 +101,33 @@ Ext.define('PVE.storage.CephFSInputPanel', {
>> },
>> ];
>> - me.columnB = [{
>> - xtype: 'proxmoxcheckbox',
>> - name: 'pveceph',
>> - reference: 'pvecephRef',
>> - bind: {
>> - disabled: '{!pvecephPossible}',
>> - value: '{pveceph}',
>> + me.columnB = [
>> + {
>> + xtype: me.isCreate ? 'textfield' : 'displayfield',
>> + name: 'keyring',
>> + fieldLabel: 'Secret',
>
> Should there be a gettext or is this enough of a technical term in this context?
That was what I thought. But some time has passed since, and I am not sure anymore if we should not place it in a gettext.
>
>> + value: me.isCreate? '' : '***********',
>
> Style nit: no space before '?' and eslint doesn't seem to catch it ;)
Thanks for catching that :)
>
>> + allowBlank: false,
>> + bind: {
>> + hidden: '{pveceph}',
>> + disabled: '{pveceph}',
>> + },
>> + },
>> + {
>> + xtype: 'proxmoxcheckbox',
>> + name: 'pveceph',
>> + reference: 'pvecephRef',
>> + bind: {
>> + disabled: '{!pvecephPossible}',
>> + value: '{pveceph}',
>> + },
>> + checked: true,
>> + uncheckedValue: 0,
>> + submitValue: false,
>> + hidden: !me.isCreate,
>> + boxLabel: gettext('Use Proxmox VE managed hyper-converged cephFS'),
>> },
>> - checked: true,
>> - uncheckedValue: 0,
>> - submitValue: false,
>> - hidden: !me.isCreate,
>> - boxLabel: gettext('Use Proxmox VE managed hyper-converged cephFS'),
>> - }];
>> + ];
>> me.callParent();
>> },
>> diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js
>> index 35568b98..3dcfea20 100644
>> --- a/www/manager6/storage/RBDEdit.js
>> +++ b/www/manager6/storage/RBDEdit.js
>> @@ -201,6 +201,17 @@ Ext.define('PVE.storage.RBDInputPanel', {
>> ];
>> me.columnB = [
>> + {
>> + xtype: me.isCreate ? 'textarea' : 'displayfield',
>> + name: 'keyring',
>> + fieldLabel: 'Keyring',
>
> Same question here
Here I rather stick with the keyring as a technical term that is used for Ceph throughout. But then again, there might be a case I did not think of and putting it in a gettext is the sensible thing to do.
>
>> + value: me.isCreate? '' : '***********',
>
> and style nit here.
>
>> + allowBlank: false,
>> + bind: {
>> + hidden: '{pveceph}',
>> + disabled: '{pveceph}',
>> + },
>> + },
>> {
>> xtype: 'proxmoxcheckbox',
>> name: 'pveceph',
next prev parent reply other threads:[~2022-01-24 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 16:44 Aaron Lauterer
2021-11-26 16:44 ` [pve-devel] [PATCH docs 2/3] storage: rbd: cephs: update authentication section Aaron Lauterer
2022-01-24 13:48 ` Fabian Ebner
2022-01-26 9:47 ` Aaron Lauterer
2021-11-26 16:44 ` [pve-devel] [PATCH docs 3/3] storage: rbd: cephs: replace PVE with {pve} Aaron Lauterer
2022-01-24 14:03 ` [pve-devel] applied: " Fabian Ebner
2021-11-29 8:26 ` [pve-devel] [PATCH manager] ui: rbd: cephfs: add keyring/secret field for external clusters Aaron Lauterer
2022-01-17 10:12 ` Aaron Lauterer
2022-01-24 12:54 ` Fabian Ebner
2022-01-24 15:26 ` Aaron Lauterer [this message]
2022-01-25 9:41 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=993d6b7d-0099-915d-55cf-7c7e9455c5a5@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox