From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate
Date: Wed, 30 Oct 2024 13:51:13 +0100 (CET) [thread overview]
Message-ID: <991386869.5117.1730292673558@webmail.proxmox.com> (raw)
In-Reply-To: <20241030121844.226245-1-m.sandoval@proxmox.com>
see my comments to the pmg-api patch(es)..
> Maximiliano Sandoval <m.sandoval@proxmox.com> hat am 30.10.2024 13:18 CET geschrieben:
>
>
> The function internally calls
> PVE::Certificate::get_certificate_fingerprint which in turn calls:
>
> ```
> my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
> ```
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> PVE/API2/Nodes.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index e8ff6dd9..1db148af 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -2567,7 +2567,7 @@ __PACKAGE__->register_method ({
> renderer => 'duration',
> },
> ssl_fingerprint => {
> - description => "The SSL fingerprint for the node certificate.",
> + description => "The SSL SHA-256 fingerprint for the node certificate.",
> type => 'string',
> optional => 1,
> },
> --
> 2.39.5
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-30 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:18 Maximiliano Sandoval
2024-10-30 12:18 ` [pve-devel] [PATCH manager 2/2] api: node: index: Add regex pattern to fingerprint parameter Maximiliano Sandoval
2024-10-30 12:51 ` Fabian Grünbichler [this message]
2024-10-30 13:35 ` [pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate Maximiliano Sandoval
2024-10-30 13:44 Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991386869.5117.1730292673558@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox