From: Fiona Ebner <f.ebner@proxmox.com>
To: "Hannes Dürr" <h.duerr@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage
Date: Mon, 18 Dec 2023 14:07:48 +0100 [thread overview]
Message-ID: <99104478-1dc4-46fb-809a-74a216fdc423@proxmox.com> (raw)
In-Reply-To: <d0d4f657-bd00-4b6a-a891-e87aed293bdb@proxmox.com>
Am 18.12.23 um 13:02 schrieb Hannes Dürr:
> On 12/14/23 15:23, Fiona Ebner wrote:
>> create_base() will tell you the actual name, you should not override it
>> with the old one. We expect it to match, but then there's no need for
>> the assignment. If it doesn't match, you'd be returning something wrong.
>> Or what am I missing?
> If i am not mistaken there is the case:
>
>
> Plugin current imagename action
>
> lvmthin: base-100-disk-1 old_base =
>
> LVMplug: -> vm-100-disk-1 not working due to collision
>
> LVMplug: -> vm-100-disk-2 call find_free_disk()
>
> lvmthin -> base-100-disk-2 != old_base
>
But in this case, returning old_base, i.e. base-100-disk-1, is wrong,
because that is not what the image is actually called. You would need to
additionally rename the image in LVM, but I don't think that's worth it.
prev parent reply other threads:[~2023-12-18 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 9:12 [pve-devel] [PATCH v2 qemu-server pve-storage 0/2] " Hannes Duerr
2023-12-07 9:12 ` [pve-devel] [PATCH v2 qemu-server pve-storage 1/2] migration: secure and use source volume names for cleanup Hannes Duerr
2023-12-14 13:58 ` Fiona Ebner
2023-12-07 9:12 ` [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage Hannes Duerr
2023-12-14 14:23 ` Fiona Ebner
2023-12-14 14:31 ` Fiona Ebner
2023-12-18 12:02 ` Hannes Dürr
2023-12-18 13:07 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99104478-1dc4-46fb-809a-74a216fdc423@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox