From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser
Date: Fri, 21 Jul 2023 15:54:09 +0200 [thread overview]
Message-ID: <98eae5be-5676-4d6f-b6e5-2c454262edba@proxmox.com> (raw)
In-Reply-To: <20230721093910.254158-3-l.wagner@proxmox.com>
unsure about this, need to think a bit and as a few other things
are pending and some vacation too I'd say let's revisit in September
(i.e., ping me then please) if I didn't get around to it.
On 21/07/2023 11:39, Lukas Wagner wrote:
> Also adding a minWidth/maxWidth so that it doesn't become comically
> large or small. The minimum size is roughly the same size as the
you can use numbers here, IMO 168 px and 200 px is not roughly the
same ^^
> search bar was before. The maxmium size is the same size as the
> results grid, making them align nicely.
Would be centering the search result grid then be good to? Also,
making it bigger if viewport size allows it, e.g. due to having more
stuff like the tags shown in there nowadays.
Also, we predominantly use integer flex values, besides consistency
one IMO has a better ration understanding there.
next prev parent reply other threads:[~2023-07-21 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:39 [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Lukas Wagner
2023-07-21 9:39 ` [pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText Lukas Wagner
2023-07-21 13:31 ` Thomas Lamprecht
2023-07-21 14:04 ` Lukas Wagner
2023-07-21 9:39 ` [pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser Lukas Wagner
2023-07-21 13:54 ` Thomas Lamprecht [this message]
2023-07-21 14:54 ` Lukas Wagner
2023-07-21 14:04 ` [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Thomas Lamprecht
2023-07-24 8:25 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98eae5be-5676-4d6f-b6e5-2c454262edba@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox