public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] api/ui: include the node ha status in resources call and show as icon
Date: Wed, 13 Nov 2024 15:36:39 +0100	[thread overview]
Message-ID: <98b69f9d-b1d4-4b3c-8638-e6696bf5389d@proxmox.com> (raw)
In-Reply-To: <20241113113259.2210108-1-d.csapak@proxmox.com>

Am 13.11.24 um 12:32 schrieb Dominik Csapak:
> we already have the information parsed, so it's cheap, and we already
> have a mechanism in place that adds 'ha-<hastate>' as a css class, so
> let's reuse that.
> 
> I chose a blue wrench, as wrenches are associated with 'maintenance',
> and because the state is different than 'online' and 'offline', but
> don't make it yellow since it's not really a 'failure' state.
> 
> Users mentioned in the forum that this would be nice:
> https://forum.proxmox.com/threads/125768/
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * make the wrench blue; and make it a little bigger so it's easier to see
> 
>  PVE/API2/Cluster.pm  |  3 +++
>  www/css/ext6-pve.css | 10 ++++++++++
>  2 files changed, 13 insertions(+)
> 
>

applied, thanks!

Might be nice to also show the state as a tooltip, to allow users to
better correlate why this icon is shown.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-11-13 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 11:32 [pve-devel] " Dominik Csapak
2024-11-13 14:36 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98b69f9d-b1d4-4b3c-8638-e6696bf5389d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal