From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 manager] ui: restore: improve warning for restoring container with same ID
Date: Thu, 7 Jul 2022 10:08:50 +0200 [thread overview]
Message-ID: <9862f60e-3fe7-a072-d4b5-724bc5df529c@proxmox.com> (raw)
In-Reply-To: <20220705085239.78671-1-f.ebner@proxmox.com>
On 05/07/2022 10:52, Fabian Ebner wrote:
> It's not clear to users that the "VM data" includes mount point
> volumes including those that are not marked for backup. This is
> different from VM restore, where volumes attached at drives not
> present in the backup will be kept around as unused volumes.
>
> Several (supposedly newer) users got tripped up by this over the
> years, the latest report being [0]. The long term plan is to make the
> restore dialog more flexible to be able to select actions for disks
> individually, but that will take a bit of time. In the mean time, make
> the warning more explicit.
>
> [0]: https://forum.proxmox.com/threads/111760/#post-482045
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v1:
> * Text for gettext() is required to be on the same line.
>
> www/manager6/window/Restore.js | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>
applied, but changed the whitespace separator to a newline (<br>) one
in a follow up, thanks!
prev parent reply other threads:[~2022-07-07 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 8:52 [pve-devel] " Fabian Ebner
2022-07-07 8:08 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9862f60e-3fe7-a072-d4b5-724bc5df529c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox