From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] lvm: wipe signatures on lvcreate
Date: Tue, 6 Jul 2021 12:39:52 +0200 [thread overview]
Message-ID: <975df09f-e974-554f-2c83-5e012729090d@proxmox.com> (raw)
In-Reply-To: <20210706095026.3785241-1-s.ivanov@proxmox.com>
On 06.07.21 11:50, Stoiko Ivanov wrote:
> With PVE 7.0 we use upstream's lvm2 packages, which seem to detect
> 'more' signatures (and refuse creating lvs when they are present)
>
> This prevents creating new disks on LVM (thick) storages as reported
> on pve-user [0].
>
> Adding -Wy to wipe signatures, and --yes (to actually wipe them
> instead of prompting) fixes the aborted lvcreate.
>
> Adding only to LVMPlugin and not to the lvcreate calls in
> LvmThinPlugin, since I assume (and my quick tests confirm) that thin
> pools are not affected by this issue..
>
> Tested on a virtual test-setup with a LVM storage on a (virtual) iscsi
> target and a local lvmthin storage.
>
> [0] https://lists.proxmox.com/pipermail/pve-user/2021-July/172660.html
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> PVE/Storage/LVMPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-07-06 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:50 [pve-devel] " Stoiko Ivanov
2021-07-06 10:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975df09f-e974-554f-2c83-5e012729090d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox