public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Aaron Lauterer" <a.lauterer@proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path
Date: Tue, 12 Apr 2022 10:35:50 +0200	[thread overview]
Message-ID: <96d8648c-30f0-c441-c3b1-198e63033a6b@proxmox.com> (raw)
In-Reply-To: <71b4db3a-0df4-123f-2635-c8706f551210@proxmox.com>

On 11.04.22 16:49, Aaron Lauterer wrote:
> On 4/11/22 14:17, Thomas Lamprecht wrote:
>> FWIW, with storage getting the following patch the symlinks get created (may need
>> an trigger for reloading udev (or manually `udevadm control -R`).
>>
>> We'd only need to check to prioritize /deb/rbd-pve/$fsid/... paths first;
>> do you have time to give that a go?
> 
> 
> The final `fi` in the renamer script was missing from the diff. Once I fixed that, it seems to work fine. Situation with a local hyperconverged cluster and an external one:

Oh sorry, seems my copy-paste has gone slightly wrong.

> ---------------------------------
> root@cephtest1:/dev/rbd-pve# tree
> .
> ├── ce99d398-91ab-4667-b4f2-307ba0bec358
> │   └── ecpool-metadata
> │       ├── vm-103-disk-0 -> ../../../rbd0
> │       ├── vm-103-disk-0-part1 -> ../../../rbd0p1
> │       ├── vm-103-disk-0-part2 -> ../../../rbd0p2
> │       ├── vm-103-disk-0-part5 -> ../../../rbd0p5
> │       ├── vm-103-disk-1 -> ../../../rbd1
> │       └── vm-103-disk-2 -> ../../../rbd2
> └── e78d9b15-d5a1-4660-a4a5-d2c1208119e9
>     └── rbd
>         └── vm-103-disk-0 -> ../../../rbd3

Glad that it works for you too, but what I actually meant is if you had time to
give the remaining perl-side of the fix a go (sorry if I did not made that clear
enough).

      reply	other threads:[~2022-04-12  8:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 11:46 Aaron Lauterer
2022-04-08  8:04 ` Fabian Grünbichler
2022-04-11  7:39   ` Thomas Lamprecht
2022-04-11  9:08     ` Aaron Lauterer
2022-04-11 12:17       ` Thomas Lamprecht
2022-04-11 14:49         ` Aaron Lauterer
2022-04-12  8:35           ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96d8648c-30f0-c441-c3b1-198e63033a6b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal