Re: [pve-devel] [PATCH ha-manager 06/15] config, env, hw: add rules read and parse methods

[Fiona Ebner <f.ebner@proxmox.com>]

Am 25.03.25 um 16:12 schrieb Daniel Kral:
> diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm
> index 1de4b69..3157e56 100644
> --- a/src/PVE/HA/Env/PVE2.pm
> +++ b/src/PVE/HA/Env/PVE2.pm
> @@ -28,6 +28,13 @@ PVE::HA::Resources::PVECT->register();
>  
>  PVE::HA::Resources->init();
>  
> +use PVE::HA::Rules;
> +use PVE::HA::Rules::Colocation;

Nit: use statements should come before other code

> +
> +PVE::HA::Rules::Colocation->register();
> +
> +PVE::HA::Rules->init();
> +
>  my $lockdir = "/etc/pve/priv/lock";
>  
>  sub new {
> @@ -188,6 +195,12 @@ sub steal_service {
>      $self->cluster_state_update();
>  }
>  
> +sub read_rules_config {
> +    my ($self) = @_;
> +
> +    return PVE::HA::Config::read_rules_config();
> +}
> +
>  sub read_group_config {
>      my ($self) = @_;
>  
> diff --git a/src/PVE/HA/Sim/Env.pm b/src/PVE/HA/Sim/Env.pm
> index b2ab231..2f73859 100644
> --- a/src/PVE/HA/Sim/Env.pm
> +++ b/src/PVE/HA/Sim/Env.pm
> @@ -20,6 +20,13 @@ PVE::HA::Sim::Resources::VirtFail->register();
>  
>  PVE::HA::Resources->init();
>  
> +use PVE::HA::Rules;
> +use PVE::HA::Rules::Colocation;

Same nit as above.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel