From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH container v2] lxc: resize: fix #2790 return message in case of disk already at size
Date: Thu, 27 Aug 2020 09:21:37 +0200 [thread overview]
Message-ID: <965d090a-5921-a3ab-b088-b5d62e7ef441@proxmox.com> (raw)
In-Reply-To: <20200826085126.24352-1-a.lauterer@proxmox.com>
On 26.08.20 10:51, Aaron Lauterer wrote:
> Otherwise the API would return an error message because returning an
> empty value is not defined in the API.
>
> By dying we avoid confusions as the return will be an error and not a
> successful call which should return a task ID.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> v1 -> v2: change from return to die as the result of the feedback to the
> first version [0]
>
> We should probably align the resize endpoint on the qemu side
> accordingly as right now it has no return values defined at all and does
> not return anything in this case.
>
> [0] https://lists.proxmox.com/pipermail/pve-devel/2020-August/044597.html
>
> src/PVE/API2/LXC.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-08-27 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 8:51 [pve-devel] " Aaron Lauterer
2020-08-27 7:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=965d090a-5921-a3ab-b088-b5d62e7ef441@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox