public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Andrei Perapiolkin <andrei.perepiolkin@open-e.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] checking output of storage plugin API - volume_rollback_is_possible(..., blockers)
Date: Thu, 15 May 2025 14:28:21 +0200 (CEST)	[thread overview]
Message-ID: <960434216.15530.1747312101948@webmail.proxmox.com> (raw)
In-Reply-To: <d32e8977-da91-427e-aa15-4937f9894fe3@open-e.com>


> Andrei Perapiolkin <andrei.perepiolkin@open-e.com> hat am 15.05.2025 13:23 CEST geschrieben:
> 
>  
> Hi Fabian,
> 
> 
> Thank you for detailed response.
> 
> > out of interest - is your plugin publicly available?
> 
> Yes, my plugin is available at https://github.com/open-e/JovianDSS-Proxmox
> 
> Regarding blockers usage: 
> https://github.com/open-e/JovianDSS-Proxmox/blob/22d0f7f8c4606d470a988fc796b391f50cabd40f/OpenEJovianDSS/Common.pm#L472

depending on what the return value/$obj there is, that looks fine to me!

you could optimize the $blocker_found variable away, and just check
whether $blockers has any elements, but that's just making the code
a bit shorter :)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-05-15 12:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 12:44 Andrei Perapiolkin via pve-devel
2025-05-15  9:16 ` Fabian Grünbichler
2025-05-15 11:23   ` Andrei Perapiolkin via pve-devel
     [not found]   ` <d32e8977-da91-427e-aa15-4937f9894fe3@open-e.com>
2025-05-15 12:28     ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=960434216.15530.1747312101948@webmail.proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=andrei.perepiolkin@open-e.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal