* [pve-devel] [PATCH pve-docs] fix #7106: replace broken link
@ 2025-12-05 9:34 Dominik Rusovac
2025-12-05 10:34 ` Friedrich Weber
0 siblings, 1 reply; 3+ messages in thread
From: Dominik Rusovac @ 2025-12-05 9:34 UTC (permalink / raw)
To: pve-devel; +Cc: drusovac
From: drusovac <d.rusovac@proxmox.com>
Broken link in section 1.11. now properly links to noVNC page.
Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
pve-intro.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-intro.adoc b/pve-intro.adoc
index 82f1495..2e16aca 100644
--- a/pve-intro.adoc
+++ b/pve-intro.adoc
@@ -232,7 +232,7 @@ infrastructure, and made it easy to provide additional services.
Also, the new REST API made it possible to replace the original user interface
with a modern client side single-page application using JavaScript. We also
replaced the old Java based VNC console code with
-https://kanaka.github.io/noVNC/[noVNC]. So you only need a web browser to manage
+https://novnc.com/info.html[noVNC]. So you only need a web browser to manage
your VMs.
The support for various storage types is another big task. Notably, {pve} was
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH pve-docs] fix #7106: replace broken link
2025-12-05 9:34 [pve-devel] [PATCH pve-docs] fix #7106: replace broken link Dominik Rusovac
@ 2025-12-05 10:34 ` Friedrich Weber
2025-12-05 11:05 ` [pve-devel] superseded: " Dominik Rusovac
0 siblings, 1 reply; 3+ messages in thread
From: Friedrich Weber @ 2025-12-05 10:34 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Rusovac
Thanks for the patch!
Two nits (both already discussed off-list):
Here it admittedly doesn't make that much of a difference, but it would
be slightly nicer if the commit message's tag prefix mentioned the
section of the docs this applies to [1], perhaps something like
'fix #7106: intro: [...]'
On 05/12/2025 10:34, Dominik Rusovac wrote:
> From: drusovac <d.rusovac@proxmox.com>
Looks like a remnant of an incomplete .gitconfig.
[1]
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] superseded: [PATCH pve-docs] fix #7106: replace broken link
2025-12-05 10:34 ` Friedrich Weber
@ 2025-12-05 11:05 ` Dominik Rusovac
0 siblings, 0 replies; 3+ messages in thread
From: Dominik Rusovac @ 2025-12-05 11:05 UTC (permalink / raw)
To: Friedrich Weber, Proxmox VE development discussion
superseded by:
https://lore.proxmox.com/pve-devel/20251205105037.126730-1-d.rusovac@proxmox.com/T/#u
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-05 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-05 9:34 [pve-devel] [PATCH pve-docs] fix #7106: replace broken link Dominik Rusovac
2025-12-05 10:34 ` Friedrich Weber
2025-12-05 11:05 ` [pve-devel] superseded: " Dominik Rusovac
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox