From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Rusovac <d.rusovac@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-docs] fix #7106: replace broken link
Date: Fri, 5 Dec 2025 11:34:33 +0100 [thread overview]
Message-ID: <95d693b5-72d8-431a-9d37-803454f4f567@proxmox.com> (raw)
In-Reply-To: <20251205093428.89109-1-d.rusovac@proxmox.com>
Thanks for the patch!
Two nits (both already discussed off-list):
Here it admittedly doesn't make that much of a difference, but it would
be slightly nicer if the commit message's tag prefix mentioned the
section of the docs this applies to [1], perhaps something like
'fix #7106: intro: [...]'
On 05/12/2025 10:34, Dominik Rusovac wrote:
> From: drusovac <d.rusovac@proxmox.com>
Looks like a remnant of an incomplete .gitconfig.
[1]
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-12-05 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 9:34 Dominik Rusovac
2025-12-05 10:34 ` Friedrich Weber [this message]
2025-12-05 11:05 ` [pve-devel] superseded: " Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d693b5-72d8-431a-9d37-803454f4f567@proxmox.com \
--to=f.weber@proxmox.com \
--cc=d.rusovac@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox