public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Felix Driessler - inett GmbH <fdriessler@inett.de>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-stoage 3/4] iscsiPlugin: add wwid
Date: Thu, 30 Apr 2026 09:12:18 +0000	[thread overview]
Message-ID: <959a7f27-df0d-4edb-8bdf-ed491dbf0892@inett.de> (raw)
In-Reply-To: <20260327101456.16614-4-fdriessler@inett.de>

From: Felix Driessler <fdriessler@inett.de><mailto:fdriessler@inett.de>

Signed-off-by: Felix Driessler <fdriessler@inett.de><mailto:fdriessler@inett.de>
---
 src/PVE/Storage/ISCSIPlugin.pm | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
index 30f4178..bb5576b 100644
--- a/src/PVE/Storage/ISCSIPlugin.pm
+++ b/src/PVE/Storage/ISCSIPlugin.pm
@@ -305,13 +305,21 @@ sub iscsi_device_list {

                     my $volid = "$channel.$id.$lun.$blockdev";

+                    my $wwid = '';
+                    my $dev = "/dev/$bdev";
+                    $dev =~ m|^(/dev/[A-Za-z0-9_\-./]+)$|
+                        or die "Invalid device path";
+                    $dev = $1;
+                    run_command(['/lib/udev/scsi_id', '-g', '-u', '-d', $dev], outfunc => sub { $wwid .= "$_[0]" });
+
                     $res->{$target}->{$volid} = {
                         'format' => 'raw',
                         'size' => int($size * 512),
                         'vmid' => 0, # not assigned to any vm
                         'channel' => int($channel),
                         'id' => int($id),
                         'lun' => int($lun),
+                        'wwid' => $wwid,
                     };

                     #print "TEST: $target $session $host,$bus,$tg,$lun $blockdev\n";

--
2.52.0




Felix Driessler
Junior Systems Engineer // #GernPerDU

[cid:inett_mail-signatur_e61f8e78-8da7-4010-bba4-70b3c208ea37.jpg]
[cid:linkedin_68516854-2409-4a36-a6b3-251a0eb72b1b.png]<https://www.linkedin.com/company/inett-gmbh>[cid:instagram_5f9ae183-9373-47c6-bb29-836f13e95d45.png]<https://www.instagram.com/inettgmbh/>[cid:facebook_f468e002-87f7-4b8e-8e0f-c80a1678f2b5.png]<https://www.facebook.com/inettgmbh>
        inett GmbH
Altenkesseler Str. 17 / B8
66115 Saarbrücken | Germany
E: fdriessler@inett.de<mailto:fdriessler@inett.de>
T: +49-681-410993-0<tel:+496814109930> | www.inett.de<https://www.inett.de>

Vertrieb
E-Mail: vertrieb@inett.de<mailto:vertrieb@inett.de>
Telefon: +49-681-410993-33<tel:+4968141099333>

Support
E-Mail: support@inett.de<mailto:support@inett.de>
Telefon: +49-681-410993-42<tel:+4968141099342>




Geschäftsführung: Marco Gabriel | Amtsgericht Saarbrücken HRB 16588


  parent reply	other threads:[~2026-04-30 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.21103ee5-34fe-43b6-b130-08f8ab2b25ae@emailsignatures365.codetwo.com>
2026-03-27 10:14 ` [PATCH pve-manager/pve-storage 0/4] extend iscsi configuration Felix Driessler
     [not found]   ` <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.d935a384-10c1-4974-ba2a-7adab51bb127@emailsignatures365.codetwo.com>
2026-03-27 10:14     ` [PATCH pve-manager 1/4] ui: Add Display of WWID for ISCSI Felix Driessler
     [not found]   ` <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.5ac71d0a-bc32-41c3-8898-7681716f7a92@emailsignatures365.codetwo.com>
2026-03-27 10:14     ` [PATCH pve-manager 2/4] ui: Add CHAP Authentication " Felix Driessler
     [not found]   ` <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.24fbb610-73bc-4d0e-8ec7-c0b5fbde4ff8@emailsignatures365.codetwo.com>
2026-03-27 10:14     ` [PATCH pve-stoage 3/4] iscsiPlugin: add wwid Felix Driessler
2026-04-23 13:06       ` Daniel Kral
2026-04-23 15:21         ` Felix Driessler - inett GmbH
2026-04-30  9:12       ` Felix Driessler - inett GmbH [this message]
     [not found]   ` <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.6c58b149-eb37-45dd-84d7-651f4453edab@emailsignatures365.codetwo.com>
2026-03-27 10:14     ` [PATCH pve-stoage 4/4] iscsiPlugin: add chap auth Felix Driessler
     [not found]   ` <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.cd811509-5a7f-4f83-8a2f-cdaa4c6afefd@emailsignatures365.codetwo.com>
2026-04-23 11:19     ` [PATCH pve-manager/pve-storage 0/4] extend iscsi configuration Felix Driessler - inett GmbH
     [not found] <f53ca227-2275-443f-84f8-48b2785269b2.2bc2ceb6-a3a3-4c49-9566-519c7d2ab20e.6280bc33-152c-4cc8-b1f7-ae5c6d73e0f3@emailsignatures365.codetwo.com>
2026-04-23 15:14 ` [PATCH pve-stoage 3/4] iscsiPlugin: add wwid Felix Drießler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=959a7f27-df0d-4edb-8bdf-ed491dbf0892@inett.de \
    --to=fdriessler@inett.de \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal