From: Christian Ebner <c.ebner@proxmox.com>
To: Philipp Hufnagl <p.hufnagl@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace
Date: Tue, 21 Nov 2023 14:40:27 +0100 (CET) [thread overview]
Message-ID: <955969958.544.1700574027669@webmail.proxmox.com> (raw)
In-Reply-To: <5a481b10-f39f-4795-9442-fbc4511d17be@proxmox.com>
> On 21.11.2023 14:12 CET Philipp Hufnagl <p.hufnagl@proxmox.com> wrote:
>
>
> Hmmm... thats very curios. I tried that on my end and it worked fine.
>
> What datastore did you try to delete? Did you have a valid
> configuration for it?
Not deleting a datastore (that works fine), I was testing if I am able
to deactivate it (or edit it in general).
Datastore config is valid, and as stated without your patches applied
it works as expected. I just double checked with a freshly created
datastore, still got the same behavior.
Cheers,
Chris
next prev parent reply other threads:[~2023-11-21 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 10:35 Philipp Hufnagl
2023-11-16 10:35 ` [pve-devel] [PATCH storage v3 1/4] pbs: Move pbs_api_connect earlyer in the code Philipp Hufnagl
2023-11-16 10:35 ` [pve-devel] [PATCH storage v3 2/4] pbs: Make it possible to reuse PBS connection for datastore API call Philipp Hufnagl
2023-11-16 10:35 ` [pve-devel] [PATCH storage v3 3/4] pbs: Extraxt check_datastore_exists from activate_storage Philipp Hufnagl
2023-11-16 10:35 ` [pve-devel] [PATCH storage v3 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks Philipp Hufnagl
2023-11-21 12:16 ` [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace Christian Ebner
2023-11-21 13:12 ` Philipp Hufnagl
2023-11-21 13:40 ` Christian Ebner [this message]
2023-11-21 14:13 ` Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=955969958.544.1700574027669@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox