From: Lukas Wagner <l.wagner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH widget-toolkit] fix #6088: notification: matcher: use more descriptive strings
Date: Tue, 28 Jan 2025 13:45:26 +0100 [thread overview]
Message-ID: <95564c81-f176-45b8-9f9d-8c9e355142ea@proxmox.com> (raw)
In-Reply-To: <20250128093159.93176-1-m.sandoval@proxmox.com>
On 2025-01-28 10:31, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> The longest translation of "At least one rule does not match" has only 4 more
> characters than the original, this is not a problem for the size we have
> available as in most cases the rules carry even longer text.
>
Tested this quickly on PBS. As discussed off-list this change makes sense to me and should
help avoid any confusion due to misleading translations as in the referenced BZ entry.
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-28 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 9:31 Maximiliano Sandoval
2025-01-28 12:45 ` Lukas Wagner [this message]
2025-01-28 14:21 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95564c81-f176-45b8-9f9d-8c9e355142ea@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal