From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server 2/5] vmstatus: make template property optional
Date: Mon, 15 Mar 2021 14:00:35 +0100 [thread overview]
Message-ID: <9435e2d8-021e-06b4-aeee-cf828ce4dd92@proxmox.com> (raw)
In-Reply-To: <20210311102650.6730-3-f.ebner@proxmox.com>
On 11.03.21 11:26, Fabian Ebner wrote:
> to avoid printing 'template: ' with 'qm status <id> --verbose' if it's false.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Breaks pve-manager without the previous patch! (e.g. guest's Start/Shutdown
> buttons won't be updated anymore)
>
we need to hold that one off for a 7.x release, ideally 7.0
> Changes from v1:
> * make property optional
>
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 1410ecb..8326e66 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2633,7 +2633,7 @@ sub vmstatus {
> $d->{diskread} = 0;
> $d->{diskwrite} = 0;
>
> - $d->{template} = PVE::QemuConfig->is_template($conf);
> + $d->{template} = 1 if PVE::QemuConfig->is_template($conf);
>
> $d->{serial} = 1 if conf_has_serial($conf);
> $d->{lock} = $conf->{lock} if $conf->{lock};
>
next prev parent reply other threads:[~2021-03-15 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:26 [pve-devel] [PATCH-SERIES v2] small improvements for parsing and printing Fabian Ebner
2021-03-11 10:26 ` [pve-devel] [PATCH v2 manager 1/5] ui: avoid errors when 'template' property is not present in guest status Fabian Ebner
2021-03-15 13:00 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [PATCH v2 qemu-server 2/5] vmstatus: make template property optional Fabian Ebner
2021-03-15 13:00 ` Thomas Lamprecht [this message]
2021-05-26 8:57 ` Fabian Ebner
2021-05-26 15:41 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [PATCH v2 container 3/5] " Fabian Ebner
2021-03-15 13:01 ` Thomas Lamprecht
2021-03-16 8:04 ` Fabian Ebner
2021-05-26 15:41 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [PATCH v2 container 4/5] config: parse: also allow empty values Fabian Ebner
2021-03-15 13:24 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-11 10:26 ` [pve-devel] [RFC/PATCH v2 container 5/5] vmstatus: make lock property optional again Fabian Ebner
2021-03-15 13:42 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9435e2d8-021e-06b4-aeee-cf828ce4dd92@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox