public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: mark strings translatable
Date: Tue, 28 Nov 2023 16:44:10 +0100	[thread overview]
Message-ID: <9416a35b-219e-4715-8378-1a2c6d21c798@proxmox.com> (raw)
In-Reply-To: <1394908429.713.1701185380305@webmail.proxmox.com>

Am 28/11/2023 um 16:29 schrieb Dietmar Maurer:
>> I'm taking on a lot of contributions to translations and the common complaint
>> I hear is that not all can be translated correctly due to such tricks (or just
>> missing gettext), most translators care much more about a correct translation
>> than some over-optimized ones than then break depending on context or target
>> language.
>>
>> Also, changing this now results in only a few new strings to be translated for
>> those languages we get common contributions for, so not really much effort to
>> catch up again.
>>
>>> So what languages are the problem exactly? Please can you
>>> give me an example?
>>
>> Any right-to-left languages could be broken.
> 
> If its only right-to-left languages, we could just add another helper
> to assemble lists in the correct order?

Those I'm rather sure of, but I'd not bet anything that they are the
only ones..

But as said, IMO such special helpers and optimizations are not really
worth the hassle, as most translators do not care and are happier if they
have more context and that the end result is OK, not that they have a
dozen strings, or so, less to translate..

I think the 

Ext.String.format(gettext('Default ({0})'), gettext('Free')) 

is really the biggest reuse one would get, and it needs no special new
helpers and  we have that pattern quite a few time, so IMO worth it.

btw. @Maximiliano: "Free" is rather a bad original text for the
component in question anyway, should be probably rather "Unrestricted".





  reply	other threads:[~2023-11-28 15:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 13:28 Maximiliano Sandoval
2023-11-28 13:31 ` Maximiliano Sandoval
2023-11-28 14:39 ` Dietmar Maurer
2023-11-28 14:46   ` Dietmar Maurer
2023-11-28 15:16     ` Thomas Lamprecht
2023-11-28 15:29       ` Dietmar Maurer
2023-11-28 15:44         ` Thomas Lamprecht [this message]
2023-11-29  8:08           ` Maximiliano Sandoval
2023-11-29  8:28             ` Thomas Lamprecht
2023-11-29  9:48       ` Dietmar Maurer
2023-11-29 10:13         ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9416a35b-219e-4715-8378-1a2c6d21c798@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal