public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info
Date: Mon, 25 Mar 2024 09:20:05 +0100	[thread overview]
Message-ID: <93fb9823-2b05-4363-8b50-f51f448dd910@proxmox.com> (raw)
In-Reply-To: <20240322135933.164404-6-a.zeidler@proxmox.com>

On 22/03/2024 14:59, Alexander Zeidler wrote:
> like on this system:
> 
>  # dmidecode -t bios
>  # dmidecode 3.4
>  Getting SMBIOS data from sysfs.
>  SMBIOS 3.0.0 present.
> 
>  Handle 0x0000, DMI type 0, 24 bytes
> 
>  Handle 0x005C, DMI type 13, 22 bytes


The manual page here states that this option also hides other entries:

> Unknown, inactive and OEM-specific entries are not displayed. Meta-data and handle references are hidden.

So especially on newer HW this might contain some actual info beyond
the SMBIOS version/metadata that gets hidden.

I mean, I have no hard feelings here, but I'm wondering if it's really
worth hiding that info if it can include potential relevant stuff.

> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  PVE/Report.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 505629c7..3a81bdb2 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -104,7 +104,7 @@ my $init_report_cmds = sub {
>  	hardware => {
>  	    order => 70,
>  	    cmds => [
> -		'dmidecode -t bios',
> +		'dmidecode -t bios -q',
>  		'lscpu',
>  		'lspci -nnk',
>  	    ],





  reply	other threads:[~2024-03-25  8:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 13:59 [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 2/9] report: add `jobs.cfg` to debug related network/load/backup/etc issues Alexander Zeidler
2024-03-25  8:08   ` Thomas Lamprecht
2024-04-11 17:07     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 3/9] report: add list of upgradable packages Alexander Zeidler
2024-03-25  8:02   ` Thomas Lamprecht
2024-04-11 17:08     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 4/9] report: add `apt-cache policy` to list recognized APT sources Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections Alexander Zeidler
2024-03-25  8:11   ` Thomas Lamprecht
2024-04-11 17:12     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info Alexander Zeidler
2024-03-25  8:20   ` Thomas Lamprecht [this message]
2024-04-11 17:13     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 7/9] report: add info of the mainboard in use Alexander Zeidler
2024-03-22 14:26   ` Aaron Lauterer
2024-04-11 17:14     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 8/9] report: add info about (un)used memory slots Alexander Zeidler
2024-03-22 18:05   ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts Alexander Zeidler
2024-03-22 16:44   ` Stoiko Ivanov
2024-03-22 18:54     ` Alexander Zeidler
2024-03-25  9:00   ` Thomas Lamprecht
2024-04-11 17:15     ` Alexander Zeidler
2024-03-25  7:52 ` [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time Thomas Lamprecht
2024-04-11 17:07   ` Alexander Zeidler
2024-04-11 17:20     ` Thomas Lamprecht
2024-04-18 15:57 ` Alexander Zeidler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93fb9823-2b05-4363-8b50-f51f448dd910@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.zeidler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal