[pve-devel] [PATCH common] schema: explicitly set min/max for vmid option

[pve-devel] [PATCH common] schema: explicitly set min/max for vmid option

[Fiona Ebner]

The associated pve_verify_vmid() method already restricts the value
to this range, but this wouldn't be visible in the API viewer for
example [0].

The verify method is also called by qemu-server's qmextract, so it's
not possible to just drop the method right now.

[0]: https://forum.proxmox.com/threads/128845/post-564526

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/JSONSchema.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 60b02cb..7589bba 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -59,8 +59,10 @@ sub get_standard_option {
 
 register_standard_option('pve-vmid', {
     description => "The (unique) ID of the VM.",
-    type => 'integer', format => 'pve-vmid',
-    minimum => 1
+    type => 'integer',
+    format => 'pve-vmid',
+    minimum => 100,
+    maximum => 999_999_999,
 });
 
 register_standard_option('pve-node', {
-- 
2.39.2

[pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

[Thomas Lamprecht]

Am 16/06/2023 um 09:35 schrieb Fiona Ebner:
> The associated pve_verify_vmid() method already restricts the value
> to this range, but this wouldn't be visible in the API viewer for
> example [0].
> 
> The verify method is also called by qemu-server's qmextract, so it's
> not possible to just drop the method right now.
> 
> [0]: https://forum.proxmox.com/threads/128845/post-564526
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/JSONSchema.pm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

let's see if we ever used values < 100 as some special thingy somwhere ;-P
(if, those things should probably just switch to another format)

Re: [pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

[Fiona Ebner]

Am 16.06.23 um 10:23 schrieb Thomas Lamprecht:
> Am 16/06/2023 um 09:35 schrieb Fiona Ebner:
>> The associated pve_verify_vmid() method already restricts the value
>> to this range, but this wouldn't be visible in the API viewer for
>> example [0].
>>
>> The verify method is also called by qemu-server's qmextract, so it's
>> not possible to just drop the method right now.
>>
>> [0]: https://forum.proxmox.com/threads/128845/post-564526
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  src/PVE/JSONSchema.pm | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>>
> 
> applied, thanks!
> 
> let's see if we ever used values < 100 as some special thingy somwhere ;-P
> (if, those things should probably just switch to another format)

Even if, the problem is limited to cases where the format verification
wouldn't be done, but the min/max limits would apply. Can that even happen?

Re: [pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

[Thomas Lamprecht]

Am 16/06/2023 um 11:01 schrieb Fiona Ebner:
>> let's see if we ever used values < 100 as some special thingy somwhere 😜
>> (if, those things should probably just switch to another format)
>
> Even if, the problem is limited to cases where the format verification
> wouldn't be done, but the min/max limits would apply. Can that even happen?

I really don't expect it, would need to manually extract the API schema
from the format and then use that to parse something – especially for such
simple formats (i.e., no format string composed of multiple properties)
I'd find that highly surprising; just saw a bit odd (perl) code already
to dare to rule the possibility of this out ;-)