From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH qemu-server] schema: fix description of migrate_downtime parameter
Date: Mon, 6 May 2024 09:53:33 +0200 [thread overview]
Message-ID: <93778638-d533-4e24-b57c-099b1ce9951c@proxmox.com> (raw)
In-Reply-To: <a6a29dc6-50e5-47c6-b776-d0cf28196609@proxmox.com>
Am 03.05.24 um 19:36 schrieb Thomas Lamprecht:
> On 03/05/2024 14:01, Fiona Ebner wrote:
>> Since commit 865ef132 ("implement dynamic migration_downtime") the
>> migration downtime will be automatically increased when migration
>> cannot converge at the very end. Update the description to reflect
>> reality.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>> PVE/QemuServer.pm | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>>
>
> applied, thanks! we might deprecate this option then, as a user cannot
> force a minimal downtime anyway anymore through it, and not sure how
> much use it has to set the initial value.
>
If the network is fast enough, the option can still be useful, because
then the downtime will be effectively shorter (than our default).
Another idea would be to make it a property string and allow setting
enforce=true (or auto-increase=false). See the related discussion here:
https://forum.proxmox.com/threads/146237/post-660507
> Deprecating would for now mostly mean adding that word to the description
> though, so no biggie.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-06 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 12:01 [pve-devel] " Fiona Ebner
2024-05-03 17:36 ` [pve-devel] applied: " Thomas Lamprecht
2024-05-06 7:53 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93778638-d533-4e24-b57c-099b1ce9951c@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox