From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH common v5 2/7] inotify: interfaces: check if bridge_vids is truthy instead of defined
Date: Mon, 11 Nov 2024 19:23:43 +0100 [thread overview]
Message-ID: <9370e480-5cce-4752-9213-cb16b083fe32@proxmox.com> (raw)
In-Reply-To: <20241002131157.227292-3-a.lauterer@proxmox.com>
Am 02.10.24 um 15:11 schrieb Aaron Lauterer:
> The old check for defined would also be true if it contained an empty
> string. By checking its truthyness, an empty string will be falsy and
> therefore the default value will be used.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> changes since:
> v4: newly added
>
> src/PVE/INotify.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-11 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 13:11 [pve-devel] [PATCH common, widget-toolkit, manager v5 0/7] fix #3893: make bridge vids configurable Aaron Lauterer
2024-10-02 13:11 ` [pve-devel] [PATCH common v5 1/7] tools: add check_list_empty function Aaron Lauterer
2024-11-11 18:19 ` Thomas Lamprecht
2024-10-02 13:11 ` [pve-devel] [PATCH common v5 2/7] inotify: interfaces: check if bridge_vids is truthy instead of defined Aaron Lauterer
2024-11-11 18:23 ` Thomas Lamprecht [this message]
2024-10-02 13:11 ` [pve-devel] [PATCH common v5 3/7] fix #3893: network: add vlan id and range parameter definitions Aaron Lauterer
2024-11-11 18:23 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-02 13:11 ` [pve-devel] [PATCH widget-toolkit v5 4/7] fix #3892: Network: add bridge vids field for bridge_vids Aaron Lauterer
2024-11-11 20:55 ` Thomas Lamprecht
2024-11-12 9:03 ` Aaron Lauterer
2024-11-12 9:55 ` Thomas Lamprecht
2024-11-12 10:29 ` Aaron Lauterer
2024-10-02 13:11 ` [pve-devel] [PATCH widget-toolkit v5 5/7] Network: add explanation for bridge vids field Aaron Lauterer
2024-11-11 20:49 ` Thomas Lamprecht
2024-10-02 13:11 ` [pve-devel] [PATCH manager v5 6/7] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2024-10-02 13:11 ` [pve-devel] [PATCH manager v5 7/7] fix #3893: ui: network: enable bridge_vids field Aaron Lauterer
2024-11-12 9:47 ` [pve-devel] [PATCH common, widget-toolkit, manager v5 0/7] fix #3893: make bridge vids configurable Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9370e480-5cce-4752-9213-cb16b083fe32@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox