From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] Revert "ui: dc: remove notify key from datacenter option view"
Date: Tue, 9 Apr 2024 15:44:11 +0200 [thread overview]
Message-ID: <9327cc60-40fb-4bfc-a9cf-bd1715b9e17d@proxmox.com> (raw)
In-Reply-To: <fc9cab02-e312-4805-a96b-d80234ef0439@proxmox.com>
On 2024-04-09 15:07, Thomas Lamprecht wrote:
> I'd propose two changes:
>
> - add a hint to redirect users to the new mechanisms so that a future
> deprecation would be more expected (if we already plan that now)
>
> - only show it if defined? While that's a bit magic, it'd avoid that
> users set it, but rather use the new mechanism.
> If, I'd never delete the setting via the UI, so that it doesn't
> suddenly disappears if one switches it from some value to default.
>
> What do you think?
I think that would make a lot of sense. I'll send a v2 with the suggested
changes.
Thanks a lot for the feedback!
--
- Lukas
prev parent reply other threads:[~2024-04-09 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 10:16 Lukas Wagner
2024-04-09 13:07 ` Thomas Lamprecht
2024-04-09 13:44 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9327cc60-40fb-4bfc-a9cf-bd1715b9e17d@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox