public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Friedrich Weber <f.weber@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] network: override device names: include Type=ether in link file
Date: Wed, 24 Apr 2024 19:47:04 +0200	[thread overview]
Message-ID: <93101a7c-7c4c-48ef-a741-a316a9e69206@proxmox.com> (raw)
In-Reply-To: <20240424165532.433172-1-f.weber@proxmox.com>

Am 24/04/2024 um 18:55 schrieb Friedrich Weber:
> Mention that the systemd link file should contain `Type=ether`, to
> make sure it only applies to Ethernet devices and does not ever apply
> to e.g. bridges or bonds which inherit the MAC address of the Ethernet
> device. Reported in the forum [0].
> 
> [0] https://forum.proxmox.com/threads/144557/post-656188
> 
> Fixes: 96c0261 ("fix #4847: network: extend section on interface naming scheme")
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
>  pve-network.adoc | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/pve-network.adoc b/pve-network.adoc
> index ef586ec..8e5fa1c 100644
> --- a/pve-network.adoc
> +++ b/pve-network.adoc
> @@ -170,6 +170,9 @@ identifier. A link file has two sections: `[Match]` determines which interfaces
>  the file will apply to; `[Link]` determines how these interfaces should be
>  configured, including their naming.
>  
> +The `[Match]` section should contain `Type=ether`, to make sure it only matches
> +Ethernet devices.

With have some users with different uplinks though, and while that is rather rare,
I'd still mention this here in passing, so that users know about the existence of
wlan or wwan, maybe even just in a footnote with a reference to:

https://www.freedesktop.org/software/systemd/man/latest/systemd.link.html#Type=

> +
>  To assign a name to a particular network device, you need a way to uniquely and
>  permanently identify that device in the `[Match]` section. One possibility is
>  to match the device's MAC address using the `MACAddress` option, as it is
> @@ -183,6 +186,7 @@ the following contents:
>  ----
>  [Match]
>  MACAddress=aa:bb:cc:dd:ee:ff
> +Type=ether
>  
>  [Link]
>  Name=enwan0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-04-24 17:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 16:55 Friedrich Weber
2024-04-24 17:47 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93101a7c-7c4c-48ef-a741-a316a9e69206@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal