public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	"Markus Frank" <m.frank@proxmox.com>,
	"Wolfgang Bumiller" <w.bumiller@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories
Date: Tue, 9 May 2023 11:31:57 +0200	[thread overview]
Message-ID: <92e79046-dc40-53ba-b0dd-7c88daff2f0d@proxmox.com> (raw)
In-Reply-To: <e48d26db-e438-ac92-6efd-10ba40e18080@proxmox.com>

to summarize what thomas and i discussed off-list:

1. i'll try to integrate arrays into the section config in pve(pbs has rudimentary support,
    but no "automatic" api integration)
    including a sensible api create/update/delete schema:
    - plan is to have the inner properties exposed but require an id parameter
      that identify which entry of which array property is to be updated
    i'll send this as a separate series, since for the remaining code it's
    not really relevant where the schema/config comes from, the internal
    api of that will probably be similar

2. Config should be per type (as mentioned in the last responses)
    and on create/update we'll not check for existence/correctness etc. for now
    (we can do that still when we broadcast the relevant info in pmxcfs in the future)

    we'll do the checks for that and insert the info in the gui and on vm start/migration/etc.

    also i'll combine some id properties when we don't require them separately, e.g. vendor/device.
    and make it clear in the description that these are for consistency checks on start

3. API will probably go to /cluster/resource/$type/$id
    where the get/create/put/delete depends on the above mentioned map id parameter for editing
    single entries
    (pending a better name than 'resource' since it's very similar to /cluster/resources
    which is an entirely different thing)

4. Most of Markus' permission structure is ok, besides replacing 'Map.' with 'Resource.'
    depending on which name we choose in the api

5. we'll probably remove the usermgmt permissions for PVEAdmin (to set it apart from the
    Administrator role)




  reply	other threads:[~2023-05-09  9:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 10:21 [pve-devel] [PATCH docs v4 0/6] feature #1027 virtio-9p/virtio-fs Markus Frank
2023-04-25 10:21 ` [pve-devel] [PATCH docs v4 1/6] added shared filesystem doc for virtio-fs & virtio-9p Markus Frank
2023-04-25 10:21 ` [pve-devel] [PATCH access-control v4 2/6] added acls for Shared Files Directories Markus Frank
2023-05-04  8:24   ` Fabian Grünbichler
2023-04-25 10:21 ` [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories Markus Frank
2023-05-03 11:26   ` Dominik Csapak
2023-05-04  8:13     ` Thomas Lamprecht
2023-05-04  8:31       ` Dominik Csapak
2023-05-04  8:42         ` Thomas Lamprecht
2023-05-04  8:57           ` Dominik Csapak
2023-05-04 10:21             ` Thomas Lamprecht
2023-05-09  9:31               ` Dominik Csapak [this message]
2023-05-04  8:24   ` Fabian Grünbichler
2023-04-25 10:21 ` [pve-devel] [PATCH manager v4 4/6] added Shared Files tab in Node Settings Markus Frank
2023-04-25 10:21 ` [pve-devel] [PATCH manager v4 5/6] added options to add virtio-9p & virtio-fs Shared Filesystems to qemu config Markus Frank
2023-04-25 10:21 ` [pve-devel] [PATCH qemu-server v4 6/6] feature #1027: virtio-9p & virtio-fs support Markus Frank
2023-05-04  8:39   ` Fabian Grünbichler
2023-05-05  8:27     ` Markus Frank
2023-05-04  8:24 ` [pve-devel] [PATCH docs v4 0/6] feature #1027 virtio-9p/virtio-fs Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92e79046-dc40-53ba-b0dd-7c88daff2f0d@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal