Re: [pve-devel] [PATCH storage/manager/docs v2] fix #3616: support multiple ceph filesystems

[Aaron Lauterer <a.lauterer@proxmox.com>]

Works like expected.

The one big problem I had previously with MDS not being ready is gone as one can see now in the task log, that it is waiting for the MDS to become active before continuing.

Tested the removal procedure outlined in the docs patch and as long as the storage is still active, it gives a nice warning.

Of course, being lazy I did not unmount it on all the nodes first and once it is removed, the nodes and child items all show question marks in the tree view. Once it gets unmounted with -f -l (force & lazy) parameters, the nodes are shown as okay again in the GUI.

Not sure if we want to check against it not being mounted on all nodes before proceeding or if that is the responsibility of the admin.

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>


On 10/25/21 16:01, Dominik Csapak wrote:
> this series support for multiple cephfs. no single patch fixes the bug,
> so it's in no commit subject... (feel free to change the commit subject
> when applying if you find one patch most appropriate?)
> 
> a user already can create multiple cephfs via 'pveceph' (or manually
> with the ceph tools), but the ui does not support it properly
> 
> storage patch can be applied independently, it only adds a new parameter
> that does nothing if not set.
> 
> changes from v1:
> * moved 'destroyfs' from api to cli only
> * removed 'destroy cephfs' from the gui
> * added docs patch to document the exact steps on how to remove a cephfs
> * added 'disable' check on remove-storages
> * change 'is mds active' check to check for specific fs_name
> 
> pve-storage:
> 
> Dominik Csapak (1):
>    cephfs: add support for multiple ceph filesystems
> 
>   PVE/Storage/CephFSPlugin.pm | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> pve-manager:
> 
> Dominik Csapak (11):
>    api: ceph-mds: get mds state when multple ceph filesystems exist
>    ui: ceph: catch missing version for service list
>    api: cephfs: refactor {ls,create}_fs
>    api: cephfs: more checks on fs create
>    api: cephfs: add fs_name to 'is mds active' check
>    ui: ceph/ServiceList: refactor controller out
>    ui: ceph/fs: show fs for active mds
>    api: cephfs: add 'fs-name' for cephfs storage
>    ui: storage/cephfs: make ceph fs selectable
>    ui: ceph/fs: allow creating multiple cephfs
>    pveceph: add 'fs destroy' command
> 
>   PVE/API2/Ceph/FS.pm                 |  31 ++-
>   PVE/CLI/pveceph.pm                  | 120 +++++++++++
>   PVE/Ceph/Services.pm                |  33 +--
>   PVE/Ceph/Tools.pm                   |  51 +++++
>   www/manager6/Makefile               |   1 +
>   www/manager6/Utils.js               |   1 +
>   www/manager6/ceph/FS.js             |  24 +--
>   www/manager6/ceph/ServiceList.js    | 313 +++++++++++++++-------------
>   www/manager6/form/CephFSSelector.js |  42 ++++
>   www/manager6/storage/CephFSEdit.js  |  25 +++
>   10 files changed, 449 insertions(+), 192 deletions(-)
>   create mode 100644 www/manager6/form/CephFSSelector.js
> 
> pve-docs:
> 
> Dominik Csapak (1):
>    pveceph: improve documentation for destroying cephfs
> 
>   pveceph.adoc | 49 +++++++++++++++++++++++++++++++++++++------------
>   1 file changed, 37 insertions(+), 12 deletions(-)
>