Re: [pve-devel] [RFC container v2 23/25] backup: implement restore for external providers

[Fiona Ebner <f.ebner@proxmox.com>]

Am 12.09.24 um 15:56 schrieb Fiona Ebner:
> Am 12.09.24 um 14:43 schrieb Fabian Grünbichler:
>> On August 13, 2024 3:28 pm, Fiona Ebner wrote:
>>> +	} elsif ($mechanism eq 'directory') {
>>> +	    my $directory = $info->{'archive-directory'}
>>> +		or die "did not get path to archive directory from backup provider\n";
>>> +	    die "not a directory '$directory'" if !-d $directory;
>>> +
>>> +	    my $rsync = ['rsync', '--stats', '-h', '-X', '-A', '--numeric-ids', '-aH', '--delete',
>>> +		'--no-whole-file', '--sparse', '--one-file-system', '--relative'];
>>> +	    push $rsync->@*, '--bwlimit', $bwlimit if $bwlimit;
>>> +	    push $rsync->@*, "${directory}/./", $rootdir;
>>
>> and this as well?
>>
> 
> Good catch, will fix!
> 

Hmm, then rsync won't be able to access the source (for my Borg example)
anymore :/

WARN: rsync: [sender] change_dir
"/run/pve-storage-borg-plugin/pve-lxc-111-2024-08-13T09:34:25Z.restore-container/filesystem"
failed: Permission denied (13)

Wit restore_tar_archive we stream the contents via stdin, can't do that
here. But maybe some kind of bind mount to make it accessible?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel