Re: [pve-devel] [PATCH container v6 2/4] config: apply_pending: get unused volid through parse_volume()

From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH container v6 2/4] config: apply_pending: get unused volid through parse_volume()
Date: Tue, 20 May 2025 15:49:19 +0200	[thread overview]
Message-ID: <922e34a1-836f-49d2-8e9b-dd1c14910d6e@proxmox.com> (raw)
In-Reply-To: <de3a2d79-e610-4c47-9439-b740401b7842@proxmox.com>

Am 20.05.25 um 15:45 schrieb Fiona Ebner:
> Am 20.05.25 um 11:08 schrieb Michael Köppl:
>> The volume ID returned by parse_volume() is used here as opposed to
>> $conf->{$opt} used for regular mount points because $conf->{$opt} is not
>> necessarily a valid volume ID in this case. This distinction is
>> important because is_volume_in_use does internally not consider
>> 'unused*' a valid volume key and does not check it. parse_volume knows
>> about 'unused*' and returns a valid volume ID.
> 
> The key is not passed to is_volume_in_use(), just the value. The
> rationale is imprecise in that regard.
> 
> Hmm, what can the value for 'unusedN' be other than a valid volume ID?
> Do you have an example? I'd rather avoid adding entries where it is not
> a volume ID to 'unusedN' in the first place.

Looking at the next patch, do you just mean it can be a volume ID whose
storage does not exist anymore?

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel