From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid migrating disk images multiple times
Date: Tue, 9 May 2023 09:34:04 +0200 [thread overview]
Message-ID: <91ef008a-9b97-90b5-4f11-365d43ebd108@proxmox.com> (raw)
In-Reply-To: <20230502131732.1875692-2-a.lauterer@proxmox.com>
Am 02.05.23 um 15:17 schrieb Aaron Lauterer:
> Scan the VM config and store the volid and full path for each storage.
> Do the same when we scan each storage. Then we can have these
> scenarios:
> * multiple storage configurations might point to the same storage
> The result is, that when scanning the storages, we find the disk image
> multiple times.
> -> we ignore them
>
Having the same storage with overlapping content types is a
configuration error (except if you use different 'content-dirs' I
guess). We can't make guarantees for locking, which e.g. leads to races
for allocation, it can lead to left-over references, etc.. Rather than
trying to handle this here, I'd prefer a warning about the
misconfiguration somewhere (maybe during storage.cfg parsing?) and/or
error out when attempting to create such a configuration. Adding
something in the docs also makes sense if there isn't yet.
next prev parent reply other threads:[~2023-05-09 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 13:17 [pve-devel] [PATCH qemu-server, container 0/2] " Aaron Lauterer
2023-05-02 13:17 ` [pve-devel] [PATCH qemu-server 1/2] migration: " Aaron Lauterer
2023-05-03 9:17 ` Fabian Grünbichler
2023-05-09 7:34 ` Fiona Ebner [this message]
2023-05-09 12:55 ` Aaron Lauterer
2023-05-09 14:43 ` Fiona Ebner
2023-05-10 9:57 ` Aaron Lauterer
2023-05-10 11:23 ` Fiona Ebner
2023-05-02 13:17 ` [pve-devel] [PATCH container 2/2] migration: avoid migrating volume " Aaron Lauterer
2023-05-03 9:07 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91ef008a-9b97-90b5-4f11-365d43ebd108@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox