public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] net: increase max queues to 128
@ 2022-11-16  4:13 Alexandre Derumier
  2022-11-16  7:37 ` Thomas Lamprecht
  2022-11-16 11:15 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Derumier @ 2022-11-16  4:13 UTC (permalink / raw)
  To: pve-devel

max supported queues tx + rx = 256, so 128 for combined
https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg03917.html

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 3b64089..da007f4 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -921,7 +921,7 @@ my $net_fmt = {
     }),
     queues => {
 	type => 'integer',
-	minimum => 0, maximum => 16,
+	minimum => 0, maximum => 128,
 	description => 'Number of packet queues to be used on the device.',
 	optional => 1,
     },
-- 
2.30.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH qemu-server] net: increase max queues to 128
  2022-11-16  4:13 [pve-devel] [PATCH qemu-server] net: increase max queues to 128 Alexandre Derumier
@ 2022-11-16  7:37 ` Thomas Lamprecht
  2022-11-16 11:15 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2022-11-16  7:37 UTC (permalink / raw)
  To: Proxmox VE development discussion, Alexandre Derumier

Am 16/11/2022 um 05:13 schrieb Alexandre Derumier:
> max supported queues tx + rx = 256, so 128 for combined
> https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg03917.html

do you really use such a relatively high amount of queues in practice?

The patch even mentions that on x86 one can only have 80 queue rx+tx
pairs, so maybe lets go for 64 as increased limit and wait on some
more user feedback for a even higher limit; at least if you don't need
that already in your production setups?


> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 3b64089..da007f4 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -921,7 +921,7 @@ my $net_fmt = {
>      }),
>      queues => {
>  	type => 'integer',
> -	minimum => 0, maximum => 16,
> +	minimum => 0, maximum => 128,
>  	description => 'Number of packet queues to be used on the device.',
>  	optional => 1,
>      },





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH qemu-server] net: increase max queues to 128
  2022-11-16  4:13 [pve-devel] [PATCH qemu-server] net: increase max queues to 128 Alexandre Derumier
  2022-11-16  7:37 ` Thomas Lamprecht
@ 2022-11-16 11:15 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2022-11-16 11:15 UTC (permalink / raw)
  To: Proxmox VE development discussion, Alexandre Derumier

Am 16/11/2022 um 05:13 schrieb Alexandre Derumier:
> max supported queues tx + rx = 256, so 128 for combined
> https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg03917.html
> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, but with limit reduced to 64 for now, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-16 11:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16  4:13 [pve-devel] [PATCH qemu-server] net: increase max queues to 128 Alexandre Derumier
2022-11-16  7:37 ` Thomas Lamprecht
2022-11-16 11:15 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal