public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] iscsi: disable Open-iSCSI login retries to avoid blocking pvestatd
Date: Fri, 11 Oct 2024 15:01:11 +0200	[thread overview]
Message-ID: <91ca7cbd-3f14-484b-82f7-052d3a5d8eae@proxmox.com> (raw)
In-Reply-To: <b896d78b-a8ee-4de4-b682-ce67098a9dc0@proxmox.com>

Thanks for the test and review!

On 11/10/2024 13:20, Mira Limbeck wrote:
> [...]
>> --- a/src/PVE/Storage/ISCSIPlugin.pm
>> +++ b/src/PVE/Storage/ISCSIPlugin.pm
>> @@ -132,6 +132,14 @@ sub iscsi_login {
>>      eval { iscsi_discovery($portals); };
>>      warn $@ if $@;
>>  
>> +    # Disable retries to avoid blocking pvestatd for too long, next iteration will retry anyway
>> +    eval {
>> +	my $cmd = [$ISCSIADM, '--mode', 'node', '--targetname', $target, '--op', 'update',
>> +	    '--name', 'node.session.initial_login_retry_max', '--value', '0'];
> As shortly discussed off-list, this should probably follow a similar
> style as the `Wrapping Arguments` section in the Perl Style Guide, but
> grouping option and value together in the same line?
> https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Arguments

Good point. I sent a v2 addressing this (and also rewording the commit
message, because I realized the v1 one was not really correct):

https://lore.proxmox.com/pve-devel/20241011125821.58224-1-f.weber@proxmox.com/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-10-11 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  9:37 Friedrich Weber
2024-10-11 11:20 ` Mira Limbeck
2024-10-11 13:01   ` Friedrich Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91ca7cbd-3f14-484b-82f7-052d3a5d8eae@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal