public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs v2 1/5] cephx-migration: Replace consumer with client
Date: Tue, 8 Sep 2026 20:42:02 +0200	[thread overview]
Message-ID: <91b23a08-e52e-4f21-979c-d44a1cfa6e6b@proxmox.com> (raw)
In-Reply-To: <20260908153932.577051-2-m.sandoval@proxmox.com>

Am 08.09.26 um 17:39 schrieb Maximiliano Sandoval:
> The later term is used more often in the Proxmox VE documentation and upstream
> [1]. The Consumer row is removed from the table to avoid being redundant after
> replacing it with Client.

I'm fine with that. "consumer" was meant to name all the individual users of
the credential without confusing them with the Ceph identity named client.admin,
and it tried to avoid suggesting that one Ceph identity corresponds to one VM
or connection.

Anyway, that is to subtle in any case (and I jumped terms here a few time,
so everything sounded odd in the end), with a fresher brain the client
terms sounds OK here.

> 
> [1] https://docs.ceph.com/en/latest/dev/cephx/
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  pveceph.adoc | 41 ++++++++++++++++++++---------------------
>  1 file changed, 20 insertions(+), 21 deletions(-)
> 
> diff --git a/pveceph.adoc b/pveceph.adoc
> index c9832ec..9664289 100644
> --- a/pveceph.adoc
> +++ b/pveceph.adoc
> @@ -1407,30 +1407,29 @@ automatically.
>  [[pveceph_cipher_support]]
>  .Check compatibility
>  Several workloads can share one Ceph user. Migrate its key only when every
> -consumer supports `aes256k`, including disconnected and external clients.
> +client supports `aes256k`, including disconnected and external clients.
>  Ceph programs from the updated {pve} packages support it; kernel clients
>  require a *running* kernel version 7.0 or newer.
>  
>  [cols="2,3",options="header"]
>  |===
> -|Consumer |Client implementation

removing the table header without removing the options="header", which
tells asciidoc that the first row will be a table header, makes this
render odd.

>  |Virtual machine with RBD disks |Userspace, unless `krbd` is enabled.
>  |Container on RBD |Always the kernel client.
>  |CephFS mount |Kernel, unless `fuse` is enabled.
>  |===
>  




  reply	other threads:[~2026-09-08 18:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 15:39 [PATCH docs v2 0/5] cephx-migration: Simplify docs Maximiliano Sandoval
2026-09-08 15:39 ` [PATCH docs v2 1/5] cephx-migration: Replace consumer with client Maximiliano Sandoval
2026-09-08 18:42   ` Thomas Lamprecht [this message]
2026-09-08 15:39 ` [PATCH docs v2 2/5] cephx-migration: Add link to CVE-2025-30156 Maximiliano Sandoval
2026-09-08 15:39 ` [PATCH docs v2 3/5] cephx-migration: Move all requirements into prelude Maximiliano Sandoval
2026-09-08 16:21   ` Jonas Theisen
2026-09-08 18:16   ` Thomas Lamprecht
2026-09-08 15:39 ` [PATCH docs v2 4/5] cephx-migration: Introduce the helper Maximiliano Sandoval
2026-09-08 15:39 ` [PATCH docs v2 5/5] cephx-migration: Simplify docs Maximiliano Sandoval
2026-09-08 18:33   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b23a08-e52e-4f21-979c-d44a1cfa6e6b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal