public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE
Date: Wed, 16 Mar 2022 17:37:13 +0100	[thread overview]
Message-ID: <91a83918-909e-d631-c405-a6ce1c2c1c9e@proxmox.com> (raw)
In-Reply-To: <20211115123756.146659-2-f.ebner@proxmox.com>

On 15.11.21 13:37, Fabian Ebner wrote:
> in the same manner as NT_STATUS_ACCESS_DENIED. It can be assumed to be
> a configuration error, so avoid showing the generic "storage <storeid>
> is not online". Reported in the community forum:
> https://forum.proxmox.com/threads/storage-is-not-online-cifs.99201/post-428858
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/Storage/CIFSPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




  reply	other threads:[~2022-03-16 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 12:37 [pve-devel] [PATCH storage 1/2] activate storage: improve error when check_connection dies Fabian Ebner
2021-11-15 12:37 ` [pve-devel] [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE Fabian Ebner
2022-03-16 16:37   ` Thomas Lamprecht [this message]
2022-03-16 16:37 ` [pve-devel] applied: [PATCH storage 1/2] activate storage: improve error when check_connection dies Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91a83918-909e-d631-c405-a6ce1c2c1c9e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal