From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #3182 #3183: change backup retention mask logic
Date: Wed, 2 Dec 2020 14:11:46 +0100 [thread overview]
Message-ID: <91926ff2-4ee0-e37b-3a93-26d06ef84c17@proxmox.com> (raw)
In-Reply-To: <20201202125631.19336-1-d.csapak@proxmox.com>
On 02.12.20 13:56, Dominik Csapak wrote:
> instead of relying on the contentTypeField (which does not need to
> exists, e.g. for iscsi), explicitely write it into the panel/icon
> mapping and check that
why not return it for iSCIS?
>
> better would be if we query the backend about storage capabilities,
> but such an api call does not exist yet, so this should be ok for now
that's not true, the content type is exactly how the backend provides that,
that's why I used it. I'd like to avoid to further duplicating info all over
the place.
next prev parent reply other threads:[~2020-12-02 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:56 Dominik Csapak
2020-12-02 13:11 ` Thomas Lamprecht [this message]
2020-12-02 13:19 ` Dominik Csapak
2020-12-02 13:27 ` Thomas Lamprecht
2020-12-02 17:04 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91926ff2-4ee0-e37b-3a93-26d06ef84c17@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox