From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH] firewall: resources: accept invalid ct state by default
Date: Fri, 15 Nov 2024 14:43:00 +0100 [thread overview]
Message-ID: <918ffc4c-c371-4d43-8c2c-849e618273b6@proxmox.com> (raw)
In-Reply-To: <508606c2-8e34-4d6f-b975-a4e96d022b13@proxmox.com>
On 11/15/24 14:13, Stefan Hanreich wrote:
> I see two ways of solving this problem:
>
> * We introduce a knob at VM level that lets you decide whether to drop
> ct invalid traffic or not. (Invalid traffic would then still be
> evaluated by the firewall rules if it's allowed in principle, as is the
> case on host-level)
>
> * We apply the host-level setting to VMs as well.
The old firewall does it like this - so maybe we should do it here as well:
* drop invalid traffic in PVEFW-HOST-IN (= INPUT chain) irregardless
of the setting
* drop invalid traffic on PVEFW-FORWARD (= FORWARD chain) if
allow_invalid is 0 (= default)
It's important not to accept it immediately, because then the rest of
the ruleset still gets evaluated, mitigating the blast radius of this
setting considerably.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-15 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 12:33 Hannes Laimer
2024-11-15 13:13 ` Stefan Hanreich
2024-11-15 13:43 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918ffc4c-c371-4d43-8c2c-849e618273b6@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox