From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v2] tui: fix FQDN validation
Date: Fri, 21 Jul 2023 16:20:35 +0200 [thread overview]
Message-ID: <913a4da9-a10e-45a3-bc15-311c5a1af98c@proxmox.com> (raw)
In-Reply-To: <20230719163130.773813-2-c.heiss@proxmox.com>
On 19/07/2023 18:31, Christoph Heiss wrote:
> Add checks to ensure that:
> * It is actually has a hostname, not just a domain name
> * Properly check if the hostname is purely numeric, which was
> broken/different to how the GUI installer does it
>
> The custom error type also allows for easier future adaptions, as the
> changes can be entirely contained to the `Fqdn` type.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-June/057845.html
>
> Changes v1 -> v2:
> * Fix & add some more unit tests
> * Add custom error type `FqdnParseError`
> * Move hostname checks directly into `Fqdn::from()`
>
> proxmox-tui-installer/src/main.rs | 5 +--
> proxmox-tui-installer/src/utils.rs | 68 ++++++++++++++++++++++++------
> 2 files changed, 57 insertions(+), 16 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-07-21 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 16:31 [pve-devel] " Christoph Heiss
2023-07-21 14:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=913a4da9-a10e-45a3-bc15-311c5a1af98c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox