public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models
Date: Mon, 19 Jun 2023 10:46:40 +0200	[thread overview]
Message-ID: <9132e8ee-5c12-2966-8c5c-8d9bad4d64f2@proxmox.com> (raw)
In-Reply-To: <20230609102701.783833-1-aderumier@odiso.com>

Am 09.06.23 um 12:27 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  PVE/QemuServer/CPUConfig.pm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
> index fb0861b..77fc682 100644
> --- a/PVE/QemuServer/CPUConfig.pm
> +++ b/PVE/QemuServer/CPUConfig.pm
> @@ -66,16 +66,28 @@ my $cpu_vendor_list = {
>      'Skylake-Client' => 'GenuineIntel',
>      'Skylake-Client-IBRS' => 'GenuineIntel',
>      'Skylake-Client-noTSX-IBRS' => 'GenuineIntel',
> +    'Skylake-Client-v4' => 'GenuineIntel',
>      'Skylake-Server' => 'GenuineIntel',
>      'Skylake-Server-IBRS' => 'GenuineIntel',
>      'Skylake-Server-noTSX-IBRS' => 'GenuineIntel',
> +    'Skylake-Server-v4' => 'GenuineIntel',
> +    'Skylake-Server-v5' => 'GenuineIntel',
>      'Cascadelake-Server' => 'GenuineIntel',
>      'Cascadelake-Server-noTSX' => 'GenuineIntel',

The above is an alias for Cascadelake-Server-v3, but -v2 is still
missing here AFAICT.

> +    'Cascadelake-Server-v4' => 'GenuineIntel',
> +    'Cascadelake-Server-v5' => 'GenuineIntel',
> +    'CooperLake' => 'GenuineIntel',
> +    'CooperLake-v2' => 'GenuineIntel',

It's Cooperlake{-v2} with a small l.

>      KnightsMill => 'GenuineIntel',
>      'Icelake-Client' => 'GenuineIntel', # depreacated, removed with QEMU 7.1
>      'Icelake-Client-noTSX' => 'GenuineIntel', # depreacated, removed with QEMU 7.1
>      'Icelake-Server' => 'GenuineIntel',
>      'Icelake-Server-noTSX' => 'GenuineIntel',
> +    'Icelake-Server-v3' => 'GenuineIntel',
> +    'Icelake-Server-v4' => 'GenuineIntel',
> +    'Icelake-Server-v5' => 'GenuineIntel',
> +    'Icelake-Server-v6' => 'GenuineIntel',
> +    'SapphireRapids' => 'GenuineIntel',
>  

I also noticed that
Denverton{-v2,-v3}
Dhyana{-v2}
Snowridge{-v2,-v3,-v4}
n270
are also missing from the list. Should we add them (maybe not n270 ;))?




  reply	other threads:[~2023-06-19  8:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 10:27 Alexandre Derumier
2023-06-19  8:46 ` Fiona Ebner [this message]
2023-06-19  9:19   ` DERUMIER, Alexandre
2023-06-19 10:07     ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9132e8ee-5c12-2966-8c5c-8d9bad4d64f2@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal