From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] mountpoint mount: activate PVE-managed volumes during preparation
Date: Fri, 12 Apr 2024 13:09:15 +0200 [thread overview]
Message-ID: <90c9797f-d7f1-40f8-b590-9a0adb8da572@proxmox.com> (raw)
In-Reply-To: <1712842343.po3jyesool.astroid@yuna.none>
Am 11.04.24 um 15:35 schrieb Fabian Grünbichler:
> On March 25, 2024 12:00 pm, Fiona Ebner wrote:
>> + PVE::Storage::activate_volumes($storage_cfg, [$volid]);
>
> shouldn't this atually pass $snapname as well? for some storages this
> does make quite the difference ;)
>
> there is also one more call in pct.pm (for the `pct fsck` command) that
> seems to lack activation before mapping.
>
Yes, totally missed that mountpoint_mount() supports passing a snapname.
Fixed in v2 and also added the activation for fsck:
https://lists.proxmox.com/pipermail/pve-devel/2024-April/062909.html
prev parent reply other threads:[~2024-04-12 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 11:00 Fiona Ebner
2024-04-11 13:35 ` Fabian Grünbichler
2024-04-12 11:09 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c9797f-d7f1-40f8-b590-9a0adb8da572@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox