Re: [pve-devel] [PATCH installer 14/14] gui: add support for pinning network interface names

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 14.10.25 um 17:03 schrieb Maximiliano Sandoval:
>> +    $dialog->show();
>> +    $dialog->run();
> There are two ways to present dialogs, either by running
> `gtk_dialog_run` which will block until the dialog is done and will
> return the response (deprecated) and then close/destroy the dialog, or
> connect to the response signal which will be emitted once there is a
> response and the dialog can be closed (as done above) but instead of
> calling `gtk_dialog_run()` one would call `gtk_window_present()` on it.
> So please run `present` instead of `run` here.
> 
> In general `present()` and `gtk_widget_show()` are kinda similar but the
> former is a wrapper around the later (among other things) and is
> preferable (might have a different effect depending on the compositor).
> 
> Incidentally using gtk_widget_show() for the purpose of displaying a
> window/dialog is deprecated in GTK 4.

Had to switch this back to run() to make the dialog window actually modal,
i.e., block interaction with the main installer window, as otherwise one
could open this multiple times, or do other odd stuff like aborting the
installation which then was blocked.

I'm fine with using something else, but it needs to be an actual dialogue
that masks the background, or we explicitly make that inactive, and for now
->run() does the job well with (currently) no downside FWICT.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel