From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, l.stechauner@proxmox.com
Subject: Re: [pve-devel] [PATCH-SERIES v3 container/qemu-server] fix #3421: allow custom storage plugins to support rootfs
Date: Wed, 2 Jun 2021 13:51:17 +0200 [thread overview]
Message-ID: <906b20b9-970d-b056-7f5b-a8e728228b85@proxmox.com> (raw)
In-Reply-To: <635d46fc-9ac5-5674-a33c-b5319d805b64@proxmox.com>
Since I just ran into it: It also breaks (at least container) backups
when there is a volume on a misconfigured storage.
Am 02.06.21 um 09:29 schrieb Fabian Ebner:
> There's an edge case with 'restart' migration for containers that breaks
> because of the new content type on startup checks:
> If there is an already running container with a volume on storage A, and
> now storage A is reconfigured to not support 'rootdir' anymore, then
> migration itself does work, but there'll be an error on startup on the
> remote node. It would be nicer if the error would appear at the start of
> the migration already.
>
> For VMs (with 'online' migration) the situation is not as bad, because
> the remote start happens earlier, so the VM will still be running on the
> original node after the error.
>
> And one can offline migrate such unstartable guests around ;)
>
> IMHO, if we add the checks for content type on startup, it's all the
> more reason to have content type checks for migration as well. For VM
> migration with the targetstorage option, there already are such checks.
>
>
> It's a tangential problem of course, your patches look fine to me:
>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
>
> Am 27.05.21 um 14:23 schrieb Lorenz Stechauner:
>> changes to v2:
>> * typo s/supoort/support/
>> * more detailed error messages
>> * implemented check also for vms
>>
>> pve-container:
>>
>> Lorenz Stechauner (1):
>> fix #3421: allow custom storage plugins to support rootfs
>>
>> src/PVE/LXC.pm | 30 ++++++++++++------------------
>> 1 file changed, 12 insertions(+), 18 deletions(-)
>>
>>
>> qemu-server:
>>
>> Lorenz Stechauner (1):
>> vm_start: check if storages of volumes support content images
>>
>> PVE/QemuServer.pm | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
prev parent reply other threads:[~2021-06-02 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 12:23 Lorenz Stechauner
2021-05-27 12:23 ` [pve-devel] [PATCH v3 container 1/1] " Lorenz Stechauner
2021-06-21 8:52 ` [pve-devel] applied: " Thomas Lamprecht
2021-05-27 12:23 ` [pve-devel] [PATCH v3 qemu-server 1/1] vm_start: check if storages of volumes support content images Lorenz Stechauner
2021-06-21 9:11 ` Thomas Lamprecht
2021-06-02 7:29 ` [pve-devel] [PATCH-SERIES v3 container/qemu-server] fix #3421: allow custom storage plugins to support rootfs Fabian Ebner
2021-06-02 11:51 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=906b20b9-970d-b056-7f5b-a8e728228b85@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox