From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys
Date: Tue, 15 Jul 2025 21:59:04 +0200 [thread overview]
Message-ID: <9053b7a6-0199-41cc-9957-464b0ca0e365@proxmox.com> (raw)
In-Reply-To: <673ff8a2-2e5e-432d-8770-5be2fce84216@proxmox.com>
Am 14.07.25 um 10:42 schrieb Lukas Wagner:
> On 2025-07-14 10:30, Gabriel Goller wrote:
>> Make we should change the Makefile to run `proxmox-biome check`?
>
> Maybe, but I think a separate make target could make more sense than including it
> in `make check`. The latter is also run during a package build process and it would
> be quite annoying to fail that because of a trivial formatting issue. We also don't do
> that for Rust, neither for clippy nor rustfmt.
+1
If, we should IMO only warn on code failing a formatting check.
> What definitely would make sense is to add biome format/check --write to the `make tidy`
> target, at the moment we seem to only run perltidy there.
Yeah, that's still missing. Any input on target name? I used `tidy` due to
correlation with perltidy's name, but would something else be more sensible
here?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-15 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 8:14 [pve-devel] [PATCH pve-guest-common v3 1/1] backup job: remove 'notification-policy' and 'notification-target' options Lukas Wagner
2025-07-09 8:14 ` [pve-devel] [PATCH manager v3 1/2] ui: remove handling of obsolete notification-policy/target settings Lukas Wagner
2025-07-11 12:34 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-09 8:14 ` [pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys Lukas Wagner
2025-07-11 12:34 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-11 15:04 ` [pve-devel] " Gabriel Goller
2025-07-14 7:26 ` Lukas Wagner
2025-07-14 8:30 ` Gabriel Goller
2025-07-14 8:42 ` Lukas Wagner
2025-07-15 19:59 ` Thomas Lamprecht [this message]
2025-07-16 9:11 ` Lukas Wagner
2025-07-11 12:34 ` [pve-devel] applied: [PATCH pve-guest-common v3 1/1] backup job: remove 'notification-policy' and 'notification-target' options Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9053b7a6-0199-41cc-9957-464b0ca0e365@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox