From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [RFC storage] content-dirs: check that all content dirs are pairwise inequal
Date: Tue, 6 Jun 2023 17:28:22 +0200 [thread overview]
Message-ID: <9037eaa6-7fe5-41db-1cf0-3cd19548e562@proxmox.com> (raw)
In-Reply-To: <20230321170325.2401819-1-f.weber@proxmox.com>
Am 21/03/2023 um 18:03 schrieb Friedrich Weber:
> This prevents strange interactions in case the same content directory
> is used for multiple content types.
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> I guess technically this is a breaking change, as users may have an
> iso+vztmpl storage that symlinks 'templates/iso' to 'templates/cache',
> which would now throw an error.
Well, then lets apply this for upcoming 8, maybe you can add a note to
our breaking changes list so that users are aware.
Also, checking this upfront and erroring in pve7to8 checker script should
not be that hard and def. help some to avoid problems during/after the
upgrade.
>
> PVE/Storage/Plugin.pm | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-06-06 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 17:03 [pve-devel] " Friedrich Weber
2023-06-06 15:28 ` Thomas Lamprecht [this message]
2023-06-07 7:46 ` [pve-devel] applied: " Friedrich Weber
2023-06-07 10:01 ` [pve-devel] " Fiona Ebner
2023-06-07 10:18 ` Friedrich Weber
2023-06-07 10:35 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9037eaa6-7fe5-41db-1cf0-3cd19548e562@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox