public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
Date: Sat, 6 Feb 2021 15:12:27 +0100	[thread overview]
Message-ID: <900ce873-7064-8700-6ccd-fa7a42998b55@proxmox.com> (raw)
In-Reply-To: <20201104014205.1369213-2-aderumier@odiso.com>

sorry for the late reply!

On 04.11.20 02:42, Alexandre Derumier wrote:
> ---
>  src/PVE/LXC.pm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 5cfcf28..ad1460c 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -291,6 +291,24 @@ sub vmstatus {
>  	} else {
>  	    $d->{cpu} = 0;
>  	}
> +
> +	if (defined(my $pressure = $cgroups->get_pressure_stat())) {
> +	    $d->{pressure} = $pressure;
> +	} else {
> +	    $d->{pressure} = {
> +		cpu => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 }

Setting avg10 to 10 seems wrong?


> +		},
> +		memory => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> +		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> +		},
> +		io => {
> +		    some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> +		    full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> +		},
> +	    };
> +	}
>      }
>  
>      my $netdev = PVE::ProcFSTools::read_proc_net_dev();
> 





  reply	other threads:[~2021-02-06 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  1:42 [pve-devel] [PATCH pve-container 0/1] " Alexandre Derumier
2020-11-04  1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
2021-02-06 14:12   ` Thomas Lamprecht [this message]
2021-02-07 13:42     ` aderumier
2022-05-25  6:52 [pve-devel] [PATCH-SERIES cluster/common/qemu-server/lxc/manager] add new metric stats in single rrd Alexandre Derumier
2022-05-25  6:52 ` [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats Alexandre Derumier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=900ce873-7064-8700-6ccd-fa7a42998b55@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal