From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Timothy Nicholson <t.nicholson@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v3] fix #5810: ui: show confirmation/warning dialog for sdn apply
Date: Mon, 18 Nov 2024 23:00:52 +0100 [thread overview]
Message-ID: <8ff448f1-dad2-47c4-a574-a0aa33e12843@proxmox.com> (raw)
In-Reply-To: <20241112120255.127300-1-t.nicholson@proxmox.com>
Am 12.11.24 um 13:02 schrieb Timothy Nicholson:
> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
> ---
>
> changes since v2 [0]:
> - changed icon
> - modified confirmation message
>
> A conditional confirmation message would definitely be nicer, I can
> send a patch for that later on today as v4.
>
> [0]: https://lore.proxmox.com/pve-devel/20241104122457.95494-1-t.nicholson@proxmox.com/
>
> www/manager6/sdn/StatusView.js | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
>
applied this one for now, it's way simpler and avoids O(n) api requests on
applying, which is quite much.
Note that I had to do with some small fixes for missing trailing commas
that eslint complained about, if you use `make install` inside www/manager
we do not enforce erroring out on warnings for convenience, but we do so
on building an actual debian package.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-18 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 12:02 [pve-devel] " Timothy Nicholson
2024-11-18 22:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff448f1-dad2-47c4-a574-a0aa33e12843@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.nicholson@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox