Re: [pve-devel] [PATCH docs v3 6/6] added noVNC clipboard documentation

[Dominik Csapak <d.csapak@proxmox.com>]

comments inline:

On 10/28/22 14:33, Markus Frank wrote:
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
>   qm.adoc | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/qm.adoc b/qm.adoc
> index 4d0c7c4..3a575bc 100644
> --- a/qm.adoc
> +++ b/qm.adoc
> @@ -693,6 +693,17 @@ Selecting `serialX` as display 'type' disables the VGA output, and redirects
>   the Web Console to the selected serial port. A configured display 'memory'
>   setting will be ignored in that case.
>   
> +You can enable the noVNC clipboard by setting 'clipboard' to 1.

please add an example how to do that with e.g. qm set

> +To use this, you need to install and enable spice-vdagent on the VM Guest:
> +`apt install spice-vdagent`

that should be a bit more generic, like 'install the spice guests tools'
as with the option description, spice-vdagent is linux (and probably even debian)
specific

you can ofc mention the package, but in general that sentens should be valid for
all guest os'

> +
> +Doing this will give you the ability to use the clipboard button of the novnc
> +console. However, when using SPICE, you have to decide which clipboard you want
> +to use, because the default SPICE clipboard implementation will be replaced by
> +the qemu-vdagent implementation, which is used by noVNC.
> +This means you cannot simply copy and paste into a SPICE session and instead
> +need to use the noVNC button, when using SPICE with noVNC-clipboard.

IMHO the sentences are too long, and a bit too technical. For an admin it should
be enough to say that if they use a display hardware where they can use the
SPICE console, only either the spice clipboard or novnc clipboard will work
and that they must decide. (how the device is named and what replaces what
is irrelevant for the admin, that's just an implementation detail and
could be changing at any point in time, at which point the docs are wrong)

> +
>   [[qm_usb_passthrough]]
>   USB Passthrough
>   ~~~~~~~~~~~~~~~