Re: [pve-devel] [PATCH manager v2 1/6] ui: remove 'Storage View'

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 02/02/2023 15:41, Dominik Csapak wrote:
> it is basically the 'Server View' but with less content, and has often
> times lead to confusion when uses accidentally selected it.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/form/ViewSelector.js | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/www/manager6/form/ViewSelector.js b/www/manager6/form/ViewSelector.js
> index 45fabd7ef..e25547c41 100644
> --- a/www/manager6/form/ViewSelector.js
> +++ b/www/manager6/form/ViewSelector.js
> @@ -26,13 +26,6 @@ Ext.define('PVE.form.ViewSelector', {
>  		text: gettext('Folder View'),
>  		groups: ['type'],
>  	    },
> -	    storage: {
> -		text: gettext('Storage View'),
> -		groups: ['node'],
> -		filterfn: function(node) {
> -		    return node.data.type === 'storage' || node.data.type === 'node';
> -		},
> -	    },
>  	    pool: {
>  		text: gettext('Pool View'),
>  		groups: ['pool'],

I'm fully agreeing with removing this useless view, just not sure if a minor
point release is right for that, but otoh. we could simply reinstate this if
we it turns out that we really got users out there depending on that view...

So, if there are no objection from any dev/user now already I'd go ahead with
applying this one.