From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Jan-Jonas Sämann" <sprinterfreak@binary-kitchen.de>
Subject: Re: [pve-devel] [PATCH v2 storage] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup
Date: Thu, 29 Oct 2020 19:21:17 +0100 [thread overview]
Message-ID: <8f4377de-7b18-461b-4882-26a7e59affa1@proxmox.com> (raw)
In-Reply-To: <20201024192709.27324-2-sprinterfreak@binary-kitchen.de>
On 24.10.20 21:27, Jan-Jonas Sämann wrote:
> This replaces a locally maintained hardware map in
> get_wear_leveling_info() by commonly used register names of
> smartmontool. Smartmontool maintains a labeled register database that
> contains a majority of drives (including versions). The current lookup
> produces false estimates, this approach hopefully provides more reliable
> data.
>
> Signed-off-by: Jan-Jonas Sämann <sprinterfreak@binary-kitchen.de>
> ---
> PVE/Diskmanage.pm | 58 +++++++++++++++++++++++------------------------
> 1 file changed, 28 insertions(+), 30 deletions(-)
so, I was about to apply this, but it fails the disks test now, could you please
adapt them so that the new checks are covered.
The respective test could be run standalone with:
# cd test
# ./run_disk_tests.pl
next prev parent reply other threads:[~2020-10-29 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:53 [pve-devel] [PATCH] disk management: Add support for additional Crucial SSDs Jan-Jonas Sämann
2020-10-22 13:30 ` Dominik Csapak
2020-10-24 19:27 ` [pve-devel] New routine get_wear_leveling_info() Jan-Jonas Sämann
2020-10-24 19:27 ` [pve-devel] [PATCH v2 storage] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup Jan-Jonas Sämann
2020-10-27 8:08 ` Thomas Lamprecht
2020-10-27 19:06 ` Jan-Jonas Sämann
2020-10-29 18:21 ` Thomas Lamprecht [this message]
2020-10-30 3:31 ` [pve-devel] Updated patch and test data Jan-Jonas Sämann
2020-10-30 3:31 ` [pve-devel] [PATCH storage v3 1/2] Update disk_tests/ssd_smart/sde data Jan-Jonas Sämann
2020-10-30 3:57 ` [pve-devel] Commit fixup Jan-Jonas Sämann
2020-10-30 3:57 ` [pve-devel] [PATCH storage v4 1/2] Update disk_tests/ssd_smart/sde data Jan-Jonas Sämann
2020-10-30 14:32 ` [pve-devel] applied: " Thomas Lamprecht
2020-10-30 3:57 ` [pve-devel] [PATCH storage v4 2/2] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup Jan-Jonas Sämann
2020-10-30 14:32 ` [pve-devel] applied: " Thomas Lamprecht
2020-10-30 3:31 ` [pve-devel] [PATCH storage v3 " Jan-Jonas Sämann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f4377de-7b18-461b-4882-26a7e59affa1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=sprinterfreak@binary-kitchen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox